fix qwen model use_casual_mask #9009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
fightfat
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9009 +/- ##
===========================================
+ Coverage 54.06% 54.13% +0.06%
===========================================
Files 650 650
Lines 103883 103883
===========================================
+ Hits 56164 56233 +69
+ Misses 47719 47650 -69 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ZHUI
approved these changes
Aug 26, 2024
ZHUI
reviewed
Aug 26, 2024
| @@ -811,7 +811,7 @@ def forward( | |||
| hidden_states = inputs_embeds | |||
| use_casual_mask = get_use_casual_mask() | |||
| # bool 4D mask | |||
| if use_casual_mask is None: | |||
| if use_casual_mask is True: | |||
There was a problem hiding this comment.
Suggested change
| if use_casual_mask is True: | |
| if use_casual_mask: |
lixcli
pushed a commit
to lixcli/PaddleNLP
that referenced
this pull request
Aug 28, 2024
Mangodadada
pushed a commit
to Mangodadada/PaddleNLP
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
修复qwen组网中use_casual_mask判断错误的问题