Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distributed]Add loss nan/inf checker #8943

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ForFishes
Copy link
Member

PR types

Breaking changes

PR changes

Others

Description

[Distributed]Add loss nan/inf checker

Copy link

paddle-bot bot commented Aug 15, 2024

Thanks for your contribution!

@@ -995,6 +995,10 @@ def _inner_training_loop(
else:
tr_loss_step = self.training_step(model, inputs)

if self.amp_dtype != "float16":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci 报错了,需要先判断, if args.fp16

Copy link
Member Author

@ForFishes ForFishes Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will fix it

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.77%. Comparing base (c88a971) to head (585f618).
Report is 251 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8943      +/-   ##
===========================================
- Coverage    55.78%   54.77%   -1.01%     
===========================================
  Files          645      639       -6     
  Lines       103700   100602    -3098     
===========================================
- Hits         57844    55105    -2739     
+ Misses       45856    45497     -359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ZHUI ZHUI merged commit 8e1f6e6 into PaddlePaddle:develop Aug 23, 2024
9 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants