Enable parallel_config to use commas as delimiters. #8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8677 +/- ##
===========================================
+ Coverage 55.43% 55.51% +0.07%
===========================================
Files 626 626
Lines 98070 98064 -6
===========================================
+ Hits 54366 54438 +72
+ Misses 43704 43626 -78 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Jul 15, 2024
paddlenlp/trainer/training_args.py
Outdated
| if " " in self.pipeline_parallel_config: | ||
| pipeline_parallel_config = set(self.pipeline_parallel_config.split(" ")) | ||
| else: | ||
| if "," in self.pipeline_parallel_config: |
DesmonDay
reviewed
Jul 16, 2024
|
|
||
| enable_release_grads = False | ||
| if args.sharding_parallel_degree > 1: | ||
| enable_release_grads = "enable_release_grads" in args.sharding_parallel_config |
There was a problem hiding this comment.
这个地方判断咋感觉不太对呢？原来的是 enable_release_grads = (... or ...)，现在的写法相当于只由 args.pipeline_parallel_config 来决定了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
上述PR添加了","作为pipeline_parallel_config,sharing_parallel_config分隔符，但遗漏了一些处理，本PR对此做了补充。