[Cherry-pick] Add release grad & sharding format & decorate_exclude_layers #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8545 +/- ##
===========================================
- Coverage 53.97% 53.96% -0.01%
===========================================
Files 618 618
Lines 96827 96834 +7
===========================================
Hits 52258 52258
- Misses 44569 44576 +7 ☔ View full report in Codecov by Sentry. |
sneaxiy
approved these changes
Jun 5, 2024
ZHUI
reviewed
Jun 5, 2024
| @@ -1671,7 +1676,7 @@ def pipeline_parallel_rank(self): | |||
| return 0 | |||
|
|
|||
| def _format_name(self, prefix, rank, degree): | |||
| size = max(2, len(str(degree))) | |||
| size = 2 | |||
There was a problem hiding this comment.
这个之前说需要支持 sharding 超过 99 的，还需要吗？
There was a problem hiding this comment.
不需要，之前的改动有问题，这次改动是对的。限制size=2就可以了。
ZHUI
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
[Cherry-pick] Add release grad & sharding format & decorate_exclude_layers