Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] rename logits_tensor_parallel_output to avoid conflict #8419

Merged
merged 1 commit into from
May 11, 2024

Conversation

SylarTiaNII
Copy link
Contributor

@SylarTiaNII SylarTiaNII commented May 11, 2024

PR types

Bug fixes

PR changes

Others

Description

relocate tensor_parallel_output in training_args.py to finetune_generation.py to avoid conflict.

Copy link

paddle-bot bot commented May 11, 2024

Thanks for your contribution!

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.43%. Comparing base (9146c1e) to head (21cfd83).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8419      +/-   ##
===========================================
- Coverage    55.43%   55.43%   -0.01%     
===========================================
  Files          616      616              
  Lines        96229    96241      +12     
===========================================
+ Hits         53346    53347       +1     
- Misses       42883    42894      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit f27fdb4 into PaddlePaddle:develop May 11, 2024
9 of 11 checks passed
DesmonDay pushed a commit to DesmonDay/PaddleNLP that referenced this pull request Jun 3, 2024
DesmonDay pushed a commit to DesmonDay/PaddleNLP that referenced this pull request Jun 3, 2024
ZHUI pushed a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants