Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "update" #8389

Merged
merged 3 commits into from
May 8, 2024
Merged

Revert "update" #8389

merged 3 commits into from
May 8, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented May 8, 2024

Reverts #8359

@ZHUI
Revert "update (#8359)"
180ea46 
This reverts commit ae0bea9.
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 8, 2024

Thanks for your contribution!

@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.36%. Comparing base (09a0ce7) to head (2d8862f).
Report is 6 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8389      +/-   ##
===========================================
- Coverage    55.36%   55.36%   -0.01%     
===========================================
  Files          614      614              
  Lines        96016    96096      +80     
===========================================
+ Hits         53164    53205      +41     
- Misses       42852    42891      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wawltor
wawltor approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 0f45875 into develop May 8, 2024
10 of 15 checks passed
@ZHUI ZHUI deleted the revert-8359-develop branch May 8, 2024 11:00
@Galaxy1458 Galaxy1458 mentioned this pull request May 9, 2024
Merged
@DrownFish19 DrownFish19 mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZHUI @wawltor @lugimzzz