Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distributed] [CustomDevices] Adapt SP on lora && polish MC2 APIs #8303

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

SylarTiaNII
Copy link
Contributor

PR types

New features & Performance optimization

PR changes

Others

Description

Copy link

paddle-bot bot commented Apr 22, 2024

Thanks for your contribution!

@SylarTiaNII SylarTiaNII force-pushed the cp_lora_sp branch 2 times, most recently from d51e95d to fa9c067 Compare April 23, 2024 08:16
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 17.18213% with 241 lines in your changes are missing coverage. Please review.

Project coverage is 55.25%. Comparing base (4039897) to head (4a0982e).
Report is 2 commits behind head on develop.

Files Patch % Lines
paddlenlp/peft/lora/lora_layers.py 14.49% 118 Missing ⚠️
paddlenlp/transformers/mc2_parallel_linear.py 18.46% 106 Missing ⚠️
paddlenlp/peft/lora/lora_model.py 25.00% 15 Missing ⚠️
paddlenlp/transformers/llama/modeling.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8303      +/-   ##
===========================================
- Coverage    55.33%   55.25%   -0.08%     
===========================================
  Files          614      613       -1     
  Lines        95341    95625     +284     
===========================================
+ Hits         52753    52837      +84     
- Misses       42588    42788     +200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit bc91dc6 into PaddlePaddle:develop Apr 23, 2024
8 of 11 checks passed
JunnYu pushed a commit that referenced this pull request Apr 24, 2024
)

* [Distributed] adapt sequence parallel on LoRA (#8235)

* [Distributed] [CustomDevices] adapt lora sp && polish MC2 APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants