Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unified_checkpoint bug #7770

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

DrownFish19
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Description

fix use_unified_checkpoint.

Copy link

paddle-bot bot commented Jan 4, 2024

Thanks for your contribution!

@DrownFish19 DrownFish19 requested a review from ZHUI January 4, 2024 03:37
ZHUI
ZHUI previously approved these changes Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (895a816) 57.30% compared to head (eab0fac) 57.28%.
Report is 3 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7770      +/-   ##
===========================================
- Coverage    57.30%   57.28%   -0.02%     
===========================================
  Files          584      584              
  Lines        87688    87729      +41     
===========================================
+ Hits         50252    50258       +6     
- Misses       37436    37471      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 7d789a8 into PaddlePaddle:develop Jan 4, 2024
@DrownFish19 DrownFish19 deleted the fix-unified-checkpoint branch January 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants