Update set_seed in trainer_utils.py #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7528 +/- ##
===========================================
- Coverage 57.92% 57.86% -0.06%
===========================================
Files 579 582 +3
Lines 86390 86492 +102
===========================================
+ Hits 50038 50046 +8
- Misses 36352 36446 +94 ☔ View full report in Codecov by Sentry. |
AnnaTrainingG
changed the title
ZHUI
reviewed
Dec 4, 2023
llm/gpt-3/run_pretrain.py
Outdated
Comment on lines
356
to
362
| init_dist_env( | ||
| training_args.tensor_parallel_degree, | ||
| training_args.sharding_parallel_degree, | ||
| training_args.pipeline_parallel_degree, | ||
| training_args.data_parallel_degree, | ||
| training_args.seed, | ||
| ) |
There was a problem hiding this comment.
这个环境已经在 training_args 里面初始化好了。
paddlenlp/trainer/trainer_utils.py
Outdated
| """ | ||
|
|
||
| # set control in tensor parallel | ||
| print("init_dist_env asdfasdfasdf niuliling") |
ZHUI
reviewed
Dec 4, 2023
| if args.use_hybrid_parallel: | ||
| from paddle.distributed.fleet.meta_parallel import get_rng_state_tracker | ||
| else: | ||
| hcg = fleet.get_hybrid_communicate_group() if hasattr(fleet.fleet, "_hcg") else None |
There was a problem hiding this comment.
hasattr(fleet.fleet, "_hcg") 这个属性是初始化分布式了之后才有？
- cpu版本paddle
- gpu版本paddle 跑cpu
- gpu版本跑gpu
2的情况下fleet.fleet._hcg是否是None。
There was a problem hiding this comment.
是的init之后才有hcg 或者init_dist_env之后才有hcg
2的时候不是none, 当未初始化的时候才是none
ZHUI
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
修复PP分布式策略下 多卡之前seed设置错误的问题