[NVIDIA] Add stage2 NCCL kernel overlap #7092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
Add @jeng1220 for vis. |
Codecov Report
@@ Coverage Diff @@
## develop #7092 +/- ##
===========================================
- Coverage 59.75% 59.75% -0.01%
===========================================
Files 559 559
Lines 82347 82359 +12
===========================================
+ Hits 49210 49213 +3
- Misses 33137 33146 +9
|
Tom-Zheng
force-pushed
the
gh_add_stage2_comm_overlap
branch
from
3bed524 to
f470b71
Compare
FeixLiu
reviewed
Sep 21, 2023
| @@ -1576,6 +1585,9 @@ def get_expected_keys(inputs, keys): | |||
| offload=cpu_offload, | |||
| **extra_kwargs, | |||
| ) | |||
| if level == "os_g": | |||
| model._set_reduce_overlap(True) | |||
There was a problem hiding this comment.
Add a flag to control whether using overlap or not? There are some constraints for the overlap, such as the logging_step should bigger than 1 for broadcast overlap and no other sync could be called during the training for broadcast overlap.
Tom-Zheng
force-pushed
the
gh_add_stage2_comm_overlap
branch
from
f470b71 to
d4397a6
Compare
|
@FeixLiu Would you please take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
This PR adds NCCL kernel overlap feature to stage2 FSDP training. It brings 1.5% E2E speedup in GPT training.