Add deepep internode implementations. #71435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
force-pushed
the
new_add_deepep_nvshmem
branch
from
774a5f2 to
bc74744
Compare
lixinqi
reviewed
Mar 6, 2025
| @@ -173,7 +178,7 @@ struct LowLatencyLayout { | |||
| // - 2 symmetric odd/even signaling buffers | |||
|
|
|||
| // Message sizes | |||
| EP_HOST_ASSERT(num_scales * sizeof(float) <= hidden); | |||
| EP_HOST_ASSERT(num_scales * static_cast<int>(sizeof(float)) <= hidden); | |||
There was a problem hiding this comment.
看num_scales和hidden是int类型，所以cast到了相同的数据类型
There was a problem hiding this comment.
已修改成static_cast<int64_t>
| num_channels * num_ranks * sizeof(int) + // Channel start offset | ||
| num_channels * num_ranks * sizeof(int) + // Channel end offset | ||
| num_channels * num_ranks * sizeof(int) * 2 + // Queue head and tail | ||
| num_ranks * num_ranks * static_cast<int>(sizeof(int)) + // prefix matrix |
Xreki
force-pushed
the
new_add_deepep_nvshmem
branch
from
b7fe54e to
6531039
Compare
lixinqi
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Communication Library
PR Types
New features
Description
pcard-67164
基于#71358 ，集成deepep多机通信实现。deepep多机实现依赖第三方库nvshmem，本PR中通过cmake实现了nvshmem的自动下载、编译、动态库的打包和安装，通过cmake选项
WITH_NVSHMEM控制，默认是OFF。因nvshmem又依赖了gdrcopy库，如果用户的gdrcopy没有安装到系统目录，则需要通过GDRCOPY_HOME来指定安装路径。待讨论和优化点：
90架构则会编译deepep代码，是否要设置成包含90架构则默认下载编译nvshmem库和deepep多机代码。