[SOT] Simplify the logic for setting VariableBase's debug_name
#71251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
GoldenStain
changed the title
GoldenStain
force-pushed
the
fix-debugName
branch
from
74a353d to
1cd0d2f
Compare
GoldenStain
force-pushed
the
fix-debugName
branch
from
1cd0d2f to
7bef65a
Compare
There was a problem hiding this comment.
PR Overview
This PR refactors the logic for setting VariableBase's debug_name to automatically infer a value from the tracker instead of accepting an explicit debug_name parameter. Key changes include:
- Removal of the debug_name parameter and its explicit assignment in the from_value functions.
- Introduction of infer_debug_name_from_tracker to generate debug names based on tracker type.
- Removal of explicit debug_name updates within OpcodeExecutor and adjustments to related tests.
Reviewed Changes
| File | Description |
|---|---|
| python/paddle/jit/sot/opcode_translator/executor/variables/base.py | Refactored debug_name initialization and removed the debug_name parameter. |
| python/paddle/jit/sot/opcode_translator/executor/function_graph.py | Updated from_value call to no longer pass debug_name. |
| python/paddle/jit/sot/opcode_translator/executor/variables/basic.py | Removed redundant debug_name property in favor of the new mechanism. |
| python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py | Removed explicit assignments of debug_name to rely on the inferred value. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
SigureMo
reviewed
Feb 27, 2025
SigureMo
changed the title
SigureMo
changed the title
debug_name
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
如果一个debug_name没有有价值的内容，那我们就舍弃它。
PCard-66972