[PIR-Auto-Parallel] Add sync shared param pass #71167
Merged
+582
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
waliwali777
force-pushed
the
refactor_sync_shared_param
branch
2 times, most recently
from
dd15992 to
8749a03
Compare
waliwali777
force-pushed
the
refactor_sync_shared_param
branch
from
8749a03 to
a3f58a5
Compare
waliwali777
force-pushed
the
refactor_sync_shared_param
branch
from
14d4059 to
848e00c
Compare
liym27
reviewed
Mar 7, 2025
| return self.num_samples | ||
|
|
||
|
|
||
| class TestSimpleNetForSemiAutoParallel: |
There was a problem hiding this comment.
继承 unittest.TestCase，修改 assert，增加allreduce 判断
| ranks = sorted(ranks) | ||
| if tuple(ranks) in self.comm_group: | ||
| return self.comm_group[tuple(ranks)].id | ||
| group = new_process_group(ranks, force_new_group=True) |
There was a problem hiding this comment.
建议加一个注释说明 force_new_group 是 False 时 存在的问题
| params, _ = get_pir_parameters(main_program) | ||
| for param in params: | ||
| users = param.all_used_ops() | ||
| for reshard_op in users: |
There was a problem hiding this comment.
这里的 users 算子不一定时 reshard_op，建议改下
| if tmp_param.name == param_name: | ||
| dy_param = tmp_param | ||
| break | ||
| assert dy_param is not None |
There was a problem hiding this comment.
代码中多处 assert 建议 补充 message
| self.comm_group[tuple(ranks)] = group.id | ||
| return group.id | ||
|
|
||
| def init_shared_params(self, main_program, startup_program): |
There was a problem hiding this comment.
这里目的是做参数同步，建议函数名改成 sync_shared_params
|
|
||
| return new_shared_params | ||
|
|
||
| def allreduce_shared_param_gradient( |
There was a problem hiding this comment.
这里目的是做梯度同步，建议函数名改成 sync_shared_param_gradient
| return params_grads | ||
|
|
||
| # Only support one shared param. | ||
| assert len(self.params_maybe_shared) == 1 |
There was a problem hiding this comment.
是的
之后可以支持更多共享参数场景
XieYunshen
previously approved these changes
Mar 8, 2025
XieYunshen
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Improvements
Description
Optimize performance for syncing shared params in PIR
reference PR : https://github.com/PaddlePaddle/Paddle/pull/65321
Pcard-89509