Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UCC for collective communication #71063

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

gaoweize
Copy link

PR Category

Communication Library

PR Types

Devs

Description

add UCC for collective communication, not fully implemented, waiting for further development

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

paddle-bot bot commented Feb 10, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Feb 10, 2025
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 确保UCC测试在CI上测试通过
  2. 需要在 AllReduce,Reduce, Broadcast,ReduceScatter, AllGather 等多个通信算子上验证正确性

: TaskStream(rank, comm_type, sync_op, use_calc_stream),
task_place_(place) {
// if (!use_calc_stream) {
// comm_event_ = std::make_shared<platform::DeviceEvent>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉废弃代码,其他地方同样处理。

// if (UseCalcStream()) {
// VLOG(5) << "Warning: The communication is on calc stream, wait here is
// "
// "useless.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉废弃代码

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants