Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Paddle Tensor】fix converter old ir issues -1 #70849

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

【Paddle Tensor】fix converter old ir issues -1 #70849

wants to merge 41 commits into from

Conversation

PolaKuma
Copy link
Contributor

@PolaKuma PolaKuma commented Jan 15, 2025 •
edited
Loading

PR Category

User Experience

PR Types

Bug fixes

Description

card-71500

  • 解决了 temporal_shift 旧ir单测问题，增加了浮点数误差，详细见图1：当shift_ratio为0.35，C为10时候，计算slice_c2会导致int(shift_ratio x C x 2)为6，但理论输出应该为7，因此加上了个小数防止误差。
  • 解决了 tile 旧ir单测问题，增加了list输入判断
  • 解决了 expand_v2 旧单测问题，len(attrs[0]['shape']) < self.dims本身不该进trt，以及value兼容问题
  • 解决了 range 旧单测问题，value兼容问题
    Screenshot 2025-01-16 at 20 34 06

lizexu123
lizexu123 reviewed Jan 20, 2025
View reviewed changes
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jan 22, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PolaKuma PolaKuma changed the title [fixbugs] pd_op.tile supports the second input as a list type [fixbugs] fix tile, temporal_shift, softmax converter old ir issues Jan 23, 2025
@PolaKuma PolaKuma changed the title [fixbugs] fix tile, temporal_shift, softmax converter old ir issues [fixbugs] fix tile, temporal_shift converter old ir issues Feb 25, 2025
PolaKuma
PolaKuma commented Mar 6, 2025
View reviewed changes
paddle/fluid/pybind/pir.cc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

传精度时候由于python版本不同，可能导致同样的数值在*2有不同结果，这里加一个警告

@PolaKuma PolaKuma changed the title [fixbugs] fix tile, temporal_shift converter old ir issues 【Paddle Tensor】fix tile, temporal_shift converter old ir issues Mar 6, 2025
@PolaKuma PolaKuma changed the title 【Paddle Tensor】fix tile, temporal_shift converter old ir issues 【Paddle Tensor】fix converter old ir issues -1 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizexu123 lizexu123 lizexu123 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PolaKuma @lizexu123