Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOT][Faster Guard] implement basic guard tree mechanism #70154

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Dec 11, 2024

PR Category

Execute Infrastructure

PR Types

Performance

Description

实现了基本的 guard tree 机制

Copy link

paddle-bot bot commented Dec 11, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 11, 2024
@zrr1999 zrr1999 changed the title [SOT][Faster Guard] add ENV_SOT_ENABLE_GUARD_TREE [SOT][Faster Guard] implement basic guard tree mechanism Dec 11, 2024
Copy link

paddle-ci-bot bot commented Dec 20, 2024

Sorry to inform you that e54a6b3's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • paddle/fluid/pybind/jit.cc: Language not supported
  • paddle/fluid/pybind/sot/guards.cc: Language not supported
  • paddle/fluid/pybind/sot/guards.h: Language not supported
  • python/paddle/jit/sot/opcode_translator/executor/tracker.py: Evaluated as low risk
  • python/paddle/jit/sot/opcode_translator/executor/variables/base.py: Evaluated as low risk
Comments suppressed due to low confidence (3)

python/paddle/jit/sot/opcode_translator/executor/executor_cache.py:135

  • [nitpick] The function name 'analyse_guard_global_object' is ambiguous. Consider renaming it to 'analyze_global_objects_in_guard' for clarity.
def analyse_guard_global_object(self, guard_fn):

python/paddle/jit/sot/opcode_translator/executor/variables/basic.py:456

  • [nitpick] The method name 'make_faster_guard' is ambiguous. It should be renamed to something more descriptive, such as 'create_faster_guard_nodes'.
def make_faster_guard(self) -> list[paddle.framework.core.GuardNode]:

python/paddle/jit/sot/opcode_translator/executor/variables/basic.py:457

  • The error message 'Only support PIR' is unclear. It should be more descriptive, such as 'PIR API must be enabled to use faster guard nodes.'
assert paddle.framework.use_pir_api(), "Only support PIR"
@zrr1999 zrr1999 marked this pull request as ready for review February 4, 2025 01:45
Copy link

paddle-ci-bot bot commented Feb 20, 2025

Sorry to inform you that 5a86b32's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant