[Typing][C-80, C-86] Add type annotations for python/paddle/incubate/{nn/functional/variable_length_memory_efficient_attention, operators/graph_khop_sampler}.py
#67197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al/variable_length_memory_efficient_attention.py`
…al/variable_length_memory_efficient_attention.py
…al/variable_length_memory_efficient_attention.py
…aph_khop_sampler.py`
|
你的PR提交成功，感谢你对开源项目的贡献! |
38 tasks
megemini
reviewed
Aug 9, 2024
| colptr: Tensor, | ||
| input_nodes: Tensor, | ||
| sample_sizes: list[int] | tuple[int, ...], | ||
| sorted_eids: Tensor | None = None, |
There was a problem hiding this comment.
Suggested change
| sorted_eids: Tensor | None = None, | |
| sorted_eids: Tensor | None = ..., |
| colptr: Tensor, | ||
| input_nodes: Tensor, | ||
| sample_sizes: list[int] | tuple[int, ...], | ||
| sorted_eids: Tensor | None = None, |
There was a problem hiding this comment.
Suggested change
| sorted_eids: Tensor | None = None, | |
| sorted_eids: Tensor | None = ..., |
| colptr: Tensor, | ||
| input_nodes: Tensor, | ||
| sample_sizes: list[int] | tuple[int, ...], | ||
| sorted_eids: Tensor | None = None, |
There was a problem hiding this comment.
Suggested change
| sorted_eids: Tensor | None = None, | |
| sorted_eids: Tensor | None = ..., |
…raph_khop_sampler.py`
…raph_khop_sampler.py`
|
@inaomIIsfarell 示例跑不通，skip 吧，理由写 |
inaomIIsfarell
changed the title
python/paddle/inbucate/{nn/functional/variable_length_memory_efficient_attention, operators/graph_khop_sampler}.py
inaomIIsfarell
changed the title
python/paddle/incubate/{nn/functional/variable_length_memory_efficient_attention, operators/graph_khop_sampler}.py
…ors/graph_khop_sampler.py`
…ctional/variable_length_memory_efficient_attention.py`
…ctional/variable_length_memory_efficient_attention.py`
…ors/graph_khop_sampler.py`
megemini
reviewed
Aug 13, 2024
|
|
||
| Examples: | ||
| .. code-block:: python | ||
|
|
||
| >>> # doctest: +REQUIRES(env:GPU) | ||
| >>> # doctest: +SKIP('Number of sample edges dismatch, the sample kernel has error.') |
…ctional/variable_length_memory_efficient_attention.py`
megemini
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM ～
@inaomIIsfarell 一般来说，不需要修改原代码里面的内容，variable_length_memory_efficient_attention.py 示例里面原来有 >>> # doctest: +REQUIRES(env:GPU) ，这里给删掉了 ... ... 不过，CI 过了，应该不影响，后面注意一下哈 ～ 🤟
sry......删多了 |
…al/variable_length_memory_efficient_attention.py`
luotao1
approved these changes
Aug 15, 2024
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
Related links
@SigureMo @megemini