[Typing][C-88,C-89] Add type annotations for python/paddle/incubate/operators/* #67104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Aug 6, 2024
| return_eids: bool = False, | ||
| flag_perm_buffer: bool = False, | ||
| name: str | None = None, | ||
| ) -> tuple[Tensor, Tensor, Tensor]: |
There was a problem hiding this comment.
根据 return_eids 使用 overload
Comment on lines
50
to
51
| pool_type: str = "sum", | ||
| out_size=None, |
There was a problem hiding this comment.
pool_type 使用 Literal
out_size 没标注 ～
|
@Sekiro-x |
megemini
reviewed
Aug 8, 2024
Comment on lines
29
to
34
| @deprecated( | ||
| since="2.4.0", | ||
| update_to="paddle.geometric.sample_neighbors", | ||
| level=1, | ||
| reason="paddle.incubate.graph_sample_neighbors will be removed in future", | ||
| ) |
There was a problem hiding this comment.
放到下面函数正式定义的地方吧， overload 的部分单独放在上面 ～
There was a problem hiding this comment.
只剩下PR-CI-Static-Check没有通过了
megemini
reviewed
Aug 9, 2024
There was a problem hiding this comment.
在示例的 graph_send_recv 调用处加上 type: ignore[operator] ，如
>>> out = paddle.incubate.graph_send_recv(x, src_index, dst_index, pool_type="sum") # type: ignore[operator]看一下 CI 的报错信息，有多个地方需要加
38 tasks
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User ExperiencePR Types
ImprovementsDescription
类型标注：
graph_sample_neighbors.py
graph_send_recv.py
Related links
@SigureMo @megemini