[Typing][B-71] Add type annotations for python/paddle/sparse/nn/layer/activation.py
#65869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Update 20240709由于 In [7]: import paddle
...: paddle.seed(2022)
...:
...: mask = paddle.rand((3, 4)) < 0.7
...: x = paddle.rand((3, 4)) * mask
...:
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
Cell In[7], line 5
2 paddle.seed(2022)
4 mask = paddle.rand((3, 4)) < 0.7
----> 5 x = paddle.rand((3, 4)) * mask
TypeError: (InvalidType) Type promotion only support calculations between floating-point numbers and between complex and real numbers. But got different data type x: float32, y: bool. (at /home/shun/Documents/Projects/paddle/megemini/Paddle/paddle/phi/common/type_promotion.h:159)个人感觉不是很合理， |
方案肯定是通过评审的，他们觉得不需要支持那就不支持呗 |
SigureMo
reviewed
Jul 9, 2024
| @@ -102,7 +102,7 @@ class Softmax(Layer): | |||
| >>> paddle.seed(2022) | |||
|
|
|||
| >>> mask = paddle.rand((3, 4)) < 0.7 | |||
| >>> x = paddle.rand((3, 4)) * mask | |||
| >>> x = paddle.to_tensor(paddle.rand((3, 4)).numpy() * mask.numpy()) | |||
There was a problem hiding this comment.
直接 x = paddle.rand([3, 4]) * mask.astype(paddle.float32) 呢？这里转 numpy 再回转就很奇怪了
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
python/paddle/sparse/nn/layer/activation.pyRelated links
@SigureMo @megemini