[Typing][B-23] Add type annotations for python/paddle/distribution/normal.py
#65849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 9, 2024
python/paddle/distribution/normal.py
Outdated
Comment on lines
36
to
43
| _NormalLoc: TypeAlias = Union[ | ||
| float, | ||
| complex, | ||
| Sequence[float], | ||
| NestedSequence[float], | ||
| npt.NDArray[Union[np.float32, np.float64]], | ||
| Tensor, | ||
| ] |
There was a problem hiding this comment.
可以把 float complex 单独作为一个 type，然后放到这里面，如：
_NormalLocBase: TypeAlias = Union[float, complex]
_NormalLoc: TypeAlias = Union[
_NormalLocBase,
Sequence[_NormalLocBase],
...
]相应的，npt 的应该也支持 complex ～
SigureMo
reviewed
Jul 10, 2024
| dtype: dtype | ||
|
|
||
| def __init__( | ||
| self, loc: _NormalLoc, scale: _NormalScale, name: str | None = None |
megemini
reviewed
Jul 11, 2024
python/paddle/distribution/normal.py
Outdated
Comment on lines
42
to
43
| Sequence[float], | ||
| NestedSequence[float], |
There was a problem hiding this comment.
这里是否可以是
Sequence[_NormalLocBase],
NestedSequence[_NormalLocBase],lognormal 那里呢？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
B23