[Typing][A-2,A-4] Add type annotations for paddle/tensor/attribute.py and paddle/tensor/einsum.py
#65255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zrr1999
changed the title
SigureMo
reviewed
Jun 18, 2024
python/paddle/tensor/einsum.py
Outdated
| @@ -323,15 +336,26 @@ def plan_reduce(plan, op, reduce_dims, keepdim): | |||
| plan.add_step(step) | |||
|
|
|||
|
|
|||
| def plan_scalar_prod(plan, op1, op2): | |||
| def plan_scalar_prod(plan: "Plan", op1: int, op2: int) -> None: | |||
python/paddle/tensor/einsum.py
Outdated
| range(start, end)[::-1], range(s.start(), s.end())[::-1] | ||
| ): | ||
| inv_map[ax] = dim | ||
| assert r is not None, "Invalid equation: missing ellipsis in output labels." |
There was a problem hiding this comment.
这里能确保 r 不是 None 么？那下面的 if r 的 else 分支是干啥的？
python/paddle/tensor/manipulation.py
Outdated
| @@ -3361,7 +3361,7 @@ def unique( | |||
| return tuple(outs) | |||
|
|
|||
|
|
|||
| def unsqueeze(x, axis, name=None): | |||
| def unsqueeze(x, axis, name=None) -> paddle.Tensor: | |||
There was a problem hiding this comment.
输入也顺手标一下吧～
另外尽可能用
if TYPE_CHECKING:
from paddle import Tensor然后标注直接用 Tensor 吧～
megemini
reviewed
Jun 18, 2024
python/paddle/tensor/einsum.py
Outdated
Comment on lines
164
to
172
| assert r is not None, "Invalid equation: missing ellipsis in output labels." | ||
| start, end = r.start(), r.end() | ||
| s = re.search(r'\.+', in_labels) | ||
| # fill the broadcast dimension indices from right to left. | ||
| if s: | ||
| for ax, dim in zip( | ||
| range(start, end)[::-1], range(s.start(), s.end())[::-1] | ||
| ): | ||
| inv_map[ax] = dim |
| @@ -460,7 +460,7 @@ def create_parameter( | |||
|
|
|||
| def create_variable_for_type_inference( | |||
| self, dtype, stop_gradient=False, shape=None | |||
| ): | |||
| ) -> paddle.Tensor: | |||
python/paddle/tensor/einsum.py
Outdated
| @@ -323,15 +336,26 @@ def plan_reduce(plan, op, reduce_dims, keepdim): | |||
| plan.add_step(step) | |||
|
|
|||
|
|
|||
| def plan_scalar_prod(plan, op1, op2): | |||
| def plan_scalar_prod(plan: "Plan", op1: int, op2: int) -> None: | |||
There was a problem hiding this comment.
from __future__ import annotations 不用引号 ～
SigureMo
changed the title
paddle/tensor/attribute.py and paddle/tensor/einsum.py
SigureMo
reviewed
Jun 18, 2024
python/paddle/tensor/attribute.py
Outdated
| @@ -13,6 +13,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
| # TODO: define functions to get tensor attributes | |||
SigureMo
reviewed
Jun 18, 2024
python/paddle/tensor/attribute.py
Outdated
| @@ -28,7 +29,7 @@ | |||
| __all__ = [] | |||
|
|
|||
|
|
|||
| def rank(input): | |||
| def rank(input: paddle.Tensor) -> paddle.Tensor: | |||
SigureMo
changed the title
paddle/tensor/attribute.py and paddle/tensor/einsum.pypaddle/tensor/attribute.py and paddle/tensor/einsum.py
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
…y` and `paddle/tensor/einsum.py` (PaddlePaddle#65255) --------- Co-authored-by: Nyakku Shigure <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
添加类型提示
Related links