[Typing][A-29] Add type annotations for paddle/nn/initializer/constant.py
#65095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
想问下 from __future__ import annotations
from ...base.initializer import ConstantInitializer
class Constant(ConstantInitializer):
def __init__(self, value: float = ...) -> None: ...我看这里是前者: |
None， |
SigureMo
reviewed
Jun 13, 2024
| def forward( | ||
| self, | ||
| var: paddle.Tensor, | ||
| block: framework.Block | paddle.pir.Block | None = None, |
There was a problem hiding this comment.
Suggested change
| block: framework.Block | paddle.pir.Block | None = None, | |
| block: paddle.pir.Block | None = None, |
统一下吧，静态图逻辑里不暴露老 IR 的概念，动静统一逻辑里不暴露静态图的概念
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
Related links
@SigureMo @megemini