-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[phi] fix sequence_mask dtype #60423
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
if in_pir_mode() and isinstance(dtype, core.VarDesc.VarType): | ||
dtype = vartype_to_datatype[dtype] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
与震哥对齐,这个 API 最好不要加这个兼容逻辑,已经发现 OpTest 存在的问题,问题先记录了,这个 PR 暂时 delay 处理
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
依赖已解,继续推进本 PR
Sorry to inform you that f81740a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
@@ -235,11 +235,6 @@ def __setattr__(self, name, val): | |||
} | |||
|
|||
|
|||
# FIXME(dev): We haven't fully verified eager mode on XPU et.al but | |||
# only GPU/CPU. Remove this after we improve this feature. | |||
_is_first_import_ = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
顺带清理了下这里,这个是 #41774 引入的,其他代码都已经清理了,但是这个全局变量没清
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可能需要确认一下,修改的这几个kernel,npu等设备kernel也是否用到了,如果用到了的话,那些kernel的参数也需要同步修改,npu等设备Kernel在PaddleCustomDevice代码仓库中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
我看了下,NPU 这里已经是 DataType,是不是不需要修改呢? |
PR types
Others
PR changes
Others
Description
去除
sequence_mask
中不必要的类型转换问题如下:
在pir模式下也会调用
TransToPhiDataType
导致原本正常的DataType
又当成ProtoDataType
再次转换,导致类型不正确TODO:
这里不删是因为,这是测 PT 的,我们开 check_pir 是测端到端理想态的,还不一样
clean code
test/sequence/CMakeLists.txt