Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.117、118、119】Migrate is_empty / isfinite / isinf into pir #58696

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Nov 5, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将 is_empty / isfinite / isinf 迁移升级至 pir,并更新单测

单测
is_empty 单测通过率 3/4 test_errors 未开启
isfinite / isinf 单测通过率 6/7 TestError.test_bad_input 未开启

Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 10, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 96c81d5 into PaddlePaddle:develop Nov 13, 2023
@DrRyanHuang DrRyanHuang deleted the is branch November 14, 2023 06:59
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants