Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.193-196】Migrate paddle.geometric.segment_max, paddle.geometric.segment_mean, paddle.geometric.segment_min, paddle.geometric.segment_sum into pir #58579

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 1, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
paddle.geometric.segment_max 迁移升级至 pir,并更新单测 单测覆盖率:5/6
paddle.geometric.segment_mean 迁移升级至 pir,并更新单测 单测覆盖率:5/6
paddle.geometric.segment_min 迁移升级至 pir,并更新单测 单测覆盖率:5/6
paddle.geometric.segment_sum 迁移升级至 pir,并更新单测 单测覆盖率:5/6

check_grad 加上 check_pir=True报错:

2023-11-01 19:44:21 --------------------------------------
2023-11-01 19:44:21 C++ Traceback (most recent call last):
2023-11-01 19:44:21 --------------------------------------
2023-11-01 19:44:21 0   paddle::framework::ThreadPoolTempl<paddle::framework::StlThreadEnvironment>::WorkerLoop(int)
2023-11-01 19:44:21 1   paddle::framework::PirInterpreter::RunInstructionBaseAsync(unsigned long)
2023-11-01 19:44:21 2   paddle::framework::PirInterpreter::RunInstructionBase(paddle::framework::InstructionBase*)
2023-11-01 19:44:21 3   paddle::framework::PhiKernelInstruction::Run()
2023-11-01 19:44:21 4   phi::KernelImpl<void (*)(phi::CPUContext const&, phi::DenseTensor const&, paddle::experimental::ScalarBase<phi::DenseTensor> const&, phi::DataType, phi::DenseTensor*), &(void phi::FullLikeKernel<double, phi::CPUContext>(phi::CPUContext const&, phi::DenseTensor const&, paddle::experimental::ScalarBase<phi::DenseTensor> const&, phi::DataType, phi::DenseTensor*))>::Compute(phi::KernelContext*)
2023-11-01 19:44:21 5   void phi::FullValue<double, phi::CPUContext, double>(phi::CPUContext const&, phi::DenseTensor*, double)
2023-11-01 19:44:21 6   phi::enforce::EnforceNotMet::EnforceNotMet(phi::ErrorSummary const&, char const*, int)
2023-11-01 19:44:21 7   phi::enforce::GetCurrentTraceBackString[abi:cxx11](bool)
2023-11-01 19:44:21 
2023-11-01 19:44:21 ----------------------
2023-11-01 19:44:21 Error Message Summary:
2023-11-01 19:44:21 ----------------------
2023-11-01 19:44:21 PreconditionNotMetError: The meta data must be valid when call the mutable data function.
2023-11-01 19:44:21   [Hint: Expected valid() == true, but received valid():0 != true:1.] (at ../paddle/phi/core/dense_tensor.cc:123)
2023-11-01 19:44:21   [operator < pd_kernel.phi_kernel > error]

@paddle-bot paddle-bot bot added the contributor External developers label Nov 1, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
@0x45f
Copy link
Contributor

0x45f commented Nov 3, 2023

ERROR: test_static (test_segment_ops.API_SegmentOpsTest) 报错是因为这个测试case中调用的是 paddle.incubate.segment_sum API,但是本PR中适配的是 paddle.geometric.segment_sum API。辛苦在这个PR中将这两个API都适配一下新IR吧,然后在尝试打开这个单测case~

@enkilee
Copy link
Contributor Author

enkilee commented Nov 6, 2023

已改

@0x45f 0x45f merged commit 551e1a3 into PaddlePaddle:develop Nov 7, 2023
@0x45f
Copy link
Contributor

0x45f commented Nov 7, 2023

反向的问题我们内部来看下~

jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Nov 7, 2023
…dle.geometric.segment_mean, paddle.geometric.segment_min, paddle.geometric.segment_sum into pir (PaddlePaddle#58579)
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
…dle.geometric.segment_mean, paddle.geometric.segment_min, paddle.geometric.segment_sum into pir (PaddlePaddle#58579)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…dle.geometric.segment_mean, paddle.geometric.segment_min, paddle.geometric.segment_sum into pir (PaddlePaddle#58579)
@xiaoguoguo626807
Copy link
Contributor

#59036 修复反向报错

SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
…dle.geometric.segment_mean, paddle.geometric.segment_min, paddle.geometric.segment_sum into pir (PaddlePaddle#58579)
@enkilee enkilee deleted the pir-api-193-195 branch December 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants