Optim fused linear grad add #55927
Merged
Optim fused linear grad add #55927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
FeixLiu
force-pushed
the
optim_fused_linear_grad_add
branch
from
1fd0700 to
17b0fc2
Compare
FeixLiu
force-pushed
the
optim_fused_linear_grad_add
branch
from
13bf600 to
39fddc6
Compare
sneaxiy
approved these changes
Aug 3, 2023
Xreki
approved these changes
Aug 3, 2023
| @@ -65,7 +66,7 @@ void FusedLinearParamGradAddImpl(const Context &ctx, | |||
| use_addto); | |||
| } | |||
|
|
|||
| if (dbias_out == nullptr) return; | |||
| if (!has_bias) return; | |||
There was a problem hiding this comment.
实际情况是，dbias_out永远都不会是nullptr？
| @@ -159,7 +161,7 @@ void FusedLinearParamGradAdd(const Context &ctx, | |||
| multi_precision = false; | |||
| } | |||
|
|
|||
| if (dbias_out) { | |||
| if (has_bias && dbias_out) { | |||
There was a problem hiding this comment.
这里dbias_out的处理逻辑要保持跟上面L136 dweight_out的处理方式一样吗？
FeixLiu
added a commit
to FeixLiu/Paddle
that referenced
this pull request
Aug 9, 2023
FeixLiu
added a commit
that referenced
this pull request
Aug 9, 2023
FeixLiu
added a commit
to FeixLiu/Paddle
that referenced
this pull request
Aug 29, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Nov 25, 2023
… optim (PaddlePaddle#56094) * skip CopyOrAdd when tmp grad is None (PaddlePaddle#55679) * Optim fused linear grad add (PaddlePaddle#55927)
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Nov 28, 2023
… optim (PaddlePaddle#56094) * skip CopyOrAdd when tmp grad is None (PaddlePaddle#55679) * Optim fused linear grad add (PaddlePaddle#55927)
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Nov 28, 2023
… optim (PaddlePaddle#56094) * skip CopyOrAdd when tmp grad is None (PaddlePaddle#55679) * Optim fused linear grad add (PaddlePaddle#55927)
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Nov 28, 2023
… optim (PaddlePaddle#56094) * skip CopyOrAdd when tmp grad is None (PaddlePaddle#55679) * Optim fused linear grad add (PaddlePaddle#55927)
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Dec 4, 2023
… optim (PaddlePaddle#56094) * skip CopyOrAdd when tmp grad is None (PaddlePaddle#55679) * Optim fused linear grad add (PaddlePaddle#55927)
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Dec 4, 2023
… optim (PaddlePaddle#56094) * skip CopyOrAdd when tmp grad is None (PaddlePaddle#55679) * Optim fused linear grad add (PaddlePaddle#55927)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Optim fused linear grad add
PCard-70444