Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][UP009] mv unnecessary utf8 declaration #52050

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Mar 23, 2023

PR types

Others

PR changes

Others

Describe

#51729 case 9

UP0009删除了不必要的utf8声明# -*- coding: utf-8 -*-

在py2中,默认在包含中文时使用gbk编码,需要在头部指定# -- coding: utf-8 --。在py3中默认使用utf8编码,不维护py2后,则无需这段描述。

  • 是否可以引入本 rule:✅ 可引入。
  • 是否可引入自动修复:✅ 可引入。

@paddle-bot
Copy link

paddle-bot bot commented Mar 23, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 23, 2023
@SigureMo
Copy link
Member

UP0009删除了不必要的utf8声明 # -*- coding: utf-8 -*-。整体来看,提高了代码的简洁性。

能不能给点有用信息,存在即合理,为什么现在不需要了?

@Liyulingyue
Copy link
Contributor Author

UP0009删除了不必要的utf8声明 # -*- coding: utf-8 -*-。整体来看,提高了代码的简洁性。

能不能给点有用信息,存在即合理,为什么现在不需要了?

我错了!改好了!

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Mar 24, 2023

@Liyulingyue 卡住的CI需要rerun下

@luotao1 luotao1 merged commit 33b289d into PaddlePaddle:develop Mar 25, 2023
@Liyulingyue Liyulingyue deleted the r9 branch April 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants