Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code example of fused_attention and fused_feedforward. #43635

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fix code example of fused_attention and fused_feedforward. #43635

merged 1 commit into from
Jun 21, 2022

Conversation

Xreki
Copy link
Contributor

@Xreki Xreki commented Jun 17, 2022

PR types

Function optimization

PR changes

Docs

Describe

按照#43474 中的review建议修改。

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Xreki Xreki force-pushed the op/fix_fused_attention_comment branch from 6a3bb5a to 49aca83 Compare June 17, 2022 10:22
zhangting2020
zhangting2020 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xreki Xreki requested a review from TCChenlong June 21, 2022 07:05
TCChenlong
TCChenlong approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xreki Xreki merged commit 223fb7b into PaddlePaddle:develop Jun 21, 2022
@Xreki Xreki deleted the op/fix_fused_attention_comment branch June 21, 2022 08:49
zhangting2020 pushed a commit to zhangting2020/Paddle that referenced this pull request Jun 21, 2022
@Xreki @zhangting2020
Fix code example of fused_attention and fused_feedforward. (PaddlePad…
ce6666a 
…dle#43635)
@zhangting2020 zhangting2020 mentioned this pull request Jun 21, 2022
Merged
lanxianghit pushed a commit that referenced this pull request Jun 22, 2022
@zhangting2020
[cherry pick] Support optional residual add in fused ops and slice la…
0660d5f 
…rge tensor for cudnn_softmax (#43719)

 [cherry pick] Support optional residual add in fused ops and slice large tensor for cudnn_softmax

cherry-pick #43635 #43681 #43474
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
@Xreki @sneaxiy
Fix code example of fused_attention and fused_feedforward. (PaddlePad…
e461279 
…dle#43635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@zhangting2020 zhangting2020 zhangting2020 approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xreki @TCChenlong @zhangting2020