Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some enforce #3301

Merged
merged 9 commits into from
Aug 8, 2017
Merged

fix some enforce #3301

merged 9 commits into from
Aug 8, 2017

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Aug 7, 2017 •
edited
Loading

Add PADDLE_ENFORCE_NOT_NULL and replaced all != nullptr

replace some enforces with richer enforces.

reyoung
reyoung approved these changes Aug 7, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gangliao
gangliao approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit 2af3500 into PaddlePaddle:develop Aug 8, 2017
@Superjomn Superjomn deleted the enforce_notnull branch August 8, 2017 02:55
@wangkuiyi
Copy link
Collaborator

I hoped that we can write PADDLE_ENFORCE(some_func() != nullptr).

@Superjomn
Copy link
Contributor Author

I will recover it in next PR.

heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@tink2123
cherry-pick for blazeface modified (PaddlePaddle#3301)
8a33b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@gangliao gangliao gangliao approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Superjomn @wangkuiyi @reyoung @gangliao