Feature/change op creation #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename operator.py to op.py because it is conflict with protobuf
reyoung
commented
Aug 4, 2017
| @@ -1,131 +0,0 @@ | |||
| import paddle.v2.framework.core as core | |||
There was a problem hiding this comment.
先把network.py删掉，直到我们完成high level api设计。
Currently use `Operator("fc", X="x", W='w1', B='b1')` as operator
creation method.
Fix PaddlePaddle#3198
reyoung
force-pushed
the
feature/change_op_creation
branch
from
8676643 to
89d33ff
Compare
jacquesqiao
reviewed
Aug 7, 2017
python/paddle/v2/framework/op.py
Outdated
| return { | ||
| 'method': __impl__, | ||
| 'name': op_proto.type, | ||
| 'all_inputs': [var.name for var in op_proto.inputs], |
There was a problem hiding this comment.
why need all, can we just use inputs/outputs?
There was a problem hiding this comment.
Because some of outputs are temporary. The outputs() API is confusing whether it contains temporary output or not.
jacquesqiao
reviewed
Aug 7, 2017
python/paddle/v2/framework/op.py
Outdated
| __impl__.all_not_temp_output_args = [ | ||
| var.name for var in op_proto.outputs if not var.temporary | ||
| ] | ||
| return { |
There was a problem hiding this comment.
maybe it's better to have a inner class
class OpWrapper {
def __init__(self, op_proto):
self.op_proto = op_proto
def inputs():
return self.op_proto.inputs
...
}the benefit is it will have a type, and we can use
self.get_op_creation_info(type).inputs()to get inputs instead of
self.get_op_creation_info(type)["inputs"]this ask coder to search the code for the dict defination
jacquesqiao
reviewed
Aug 7, 2017
| if core.is_compile_gpu(): | ||
| places.append(core.GPUPlace(0)) | ||
|
|
||
| for place in places: | ||
| for in_name in func.all_input_args: | ||
| if hasattr(self, "inputs") and in_name in self.inputs: | ||
| for in_name in Operator.get_op_input_names(self.type): |
There was a problem hiding this comment.
If we have a OpWrapper class, we can use
for in_name in Operator.Info("type").inputs():
passand remove get_op_input_names
reyoung
force-pushed
the
feature/change_op_creation
branch
from
effd1c7 to
9f81635
Compare
reyoung
force-pushed
the
feature/change_op_creation
branch
from
3fc40f9 to
460326f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
Operator("fc", X="x", W='w1', B='b1')as operatorcreation method.
Fix #3198