crossentropy grad op #3186
Merged
crossentropy grad op #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
requested changes
Aug 2, 2017
paddle/framework/operator.h
Outdated
| @@ -319,5 +319,14 @@ class OperatorWithKernel : public OperatorBase { | |||
| virtual void InferShape(const InferShapeContext& ctx) const = 0; | |||
| }; | |||
|
|
|||
| namespace op_helpers { | |||
paddle/operators/cross_entropy_op.cc
Outdated
| auto X_grad = ctx.Output<Tensor>(GenGradName("X")); | ||
| // auto Y_grad = ctx.Input<Tensor>(GenGradName("Y")); | ||
| auto X = ctx.Input<Tensor>("X"); | ||
| // auto Y = ctx.Input<Tensor>("Y"); |
There was a problem hiding this comment.
Delete unwanted code instead of commenting them out.
paddle/operators/cross_entropy_op.h
Outdated
| @@ -21,25 +21,53 @@ namespace operators { | |||
| template <typename Place, typename T> | |||
| class OnehotCrossEntropyOpKernel : public OpKernel { | |||
| public: | |||
| constexpr T LOG_THRESHOLD() const { return static_cast<T>(1e-20); } | |||
| constexpr T kLOG_THRESHOLD() const { return static_cast<T>(1e-20); } | |||
There was a problem hiding this comment.
Let's follow the code style https://google.github.io/styleguide/cppguide.html#Constant_Names and change kLOG_THRESHOLD into
static const double kLogThreshold = 1e-20;We mustn't define it as a function template without any constaint on type T, as it is obvious that we cannoot type cast 1e-20 into any integral value like LOG_THRESHOLD<int>().
Let's fix this special case in this PR and fix others in another separate PR.
wangkuiyi
approved these changes
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.