MKLDNN layout: Gaussian random layout #11523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozga-intel
changed the title
|
@luotao1 Could you continue the checking of this code, please. |
luotao1
reviewed
Jun 19, 2018
| #include "paddle/fluid/platform/device_context.h" | ||
| #include "paddle/fluid/platform/mkldnn_helper.h" | ||
|
|
||
| #include "paddle/fluid/framework/eigen.h" |
There was a problem hiding this comment.
Are the including headers in line 15-line 24all needed? There are only two headers in gaussian_random_op.cc
Paddle/paddle/fluid/operators/gaussian_random_op.cc
Lines 15 to 16 in d00a043
| using mkldnn::primitive; | ||
| using mkldnn::softmax_forward; | ||
| using mkldnn::prop_kind; | ||
| using mkldnn::stream; |
There was a problem hiding this comment.
Are line 28-37 all needed? please remove the unused one, such as mkldnn::softmax_forward.
mozga-intel
force-pushed
the
mozga-intel/Gausian_random_mkldnn_layout
branch
from
04d47b5 to
9d28678
Compare
mozga-intel
force-pushed
the
mozga-intel/Gausian_random_mkldnn_layout
branch
from
9d28678 to
7b9aa60
Compare
|
@luotao1 Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gaussian random operator of the MKLDNN significantly speed up the resnet model. The some function of mkldnn are used directly in this operator in order to get the better performance.