Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the kill and death scores of a
ScoreMatchModule
publicly visible.Motivation
We use this to check if a map cares about kills or not.
Specifically, if someone enters a scorebox on a map where there is a kill score, we scale their droplet reward with the number of points the scorebox is worth, since the 10 point scorebox on BlockBlock is more significant than a 3 point scorebox on Facility. On maps with no kill score, the point value of the scorebox likely is not related to how important or difficult it is to score, so we use a fixed value instead.
Since we're using the kill score when looking at a scorebox, we can't easily get the kill score off a
MatchPlayerScoreEvent
.The death score is also made public since it seems weird to only provide the one.