RNMT-6187 Prepare our fork of cordova-android 12.0.0 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our fix is already integrated into upstream, but we had a better test coverage internally. This commit includes the extra test coverage. References https://outsystemsrd.atlassian.net/browse/RNMT-5258 References https://outsystemsrd.atlassian.net/browse/RNMT-5730 References https://outsystemsrd.atlassian.net/browse/RNMT-6187
BREAKING CHANGE: This changes the default value of FilterTouchesWhenObscured We had a customer asking for the addition of a configuration to our Android’s manifest to prevent touches when the app is obscured, as this was flagged by the google store as a security issue. Therefore, we should provide the ability for our customers to add this specific configuration. References https://outsystemsrd.atlassian.net/browse/RNMT-5303 References https://outsystemsrd.atlassian.net/browse/RNMT-5392 References https://outsystemsrd.atlassian.net/browse/RNMT-5730 References https://outsystemsrd.atlassian.net/browse/RNMT-6187
Fixes the application crashing when webview redirects to error screen. This customisation has historically been in a patch in the template. Since we now have a fork, all customisations should be in the fork. References https://outsystemsrd.atlassian.net/browse/RNMT-1890 References https://outsystemsrd.atlassian.net/browse/RNMT-5730 References https://outsystemsrd.atlassian.net/browse/RNMT-6187
The changes made to splash screens in Cordova-android 11 are in line with the UX Google wants. Unfortunately, this removes the support for custom full image splash screens altogether. To keep the support for the new Splash Screen API provided out of the box by Cordova but also support the full image splash screens, we're reintroducing the removed code while keeping the new logic as well. So what does this do now? - If no custom splash screens were provided and the ShowSplashScreenSpinner preference is not enabled, only the new Android splash is presented - Otherwise, the Android splash is dismissed as ASAP and the old experience is used - The show() method is now available in the clobber once again, because the old splash screen can still be re-shown (the new one can't, hence why this method was removed) - It's possible to dismiss the splash screen via hide() when using AutoHideSplashScreen (this was possible before but was removed in this new experience) References https://outsystemsrd.atlassian.net/browse/RNMT-5730 References https://outsystemsrd.atlassian.net/browse/RNMT-6187
usernuno
requested review from
andredestro,
EiyuuZack,
Chuckytuh,
cmfsotelo,
tiagoappereira and
sandrarodrigues76
and removed request for
a team
tiagoappereira
approved these changes
Jul 26, 2023
Chuckytuh
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 5 commits above the 12.0.0 version from upstream:
error.html(from our 11.0.0 fork)The remaining changes from our 11.0.0 fork are already handled in 12.0.0.