Add Smart Battery blocking trait conforming to SBS spec #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tullom
requested review from
jeffglaum,
akshat2112,
RobertZ2011,
felipebalbi,
jerrysxie,
madeleyneVaca and
sukomath
tullom
force-pushed
the
blocking-traits-smart-battery
branch
from
45375de to
fa198db
Compare
jerrysxie
approved these changes
Feb 7, 2025
felipebalbi
requested changes
Feb 7, 2025
tullom
force-pushed
the
blocking-traits-smart-battery
branch
from
fa198db to
3db2199
Compare
tullom
force-pushed
the
blocking-traits-smart-battery
branch
4 times, most recently
from
d82a7dd to
5facaee
Compare
felipebalbi
requested changes
Feb 12, 2025
tullom
force-pushed
the
blocking-traits-smart-battery
branch
from
5facaee to
f809d56
Compare
felipebalbi
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Large LOC due mostly to new structs and lots of documentation. I have segmented the commits into 3 parts to make it easier to review. The rustdocs are glorious 😎