Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust-Axum] Fix compilation error when validate is used on Nullable values #20100

Conversation

Victoria-Casasampere-BeeTheData
Copy link
Contributor

@Victoria-Casasampere-BeeTheData Victoria-Casasampere-BeeTheData commented Nov 14, 2024

Fixes different compilation errors that can occur when Validate is derived in structures that use Nullable in its fields. This has been done in the same way as the library implementation of the different traits in Option.

Updating the library was necessary to have access to validator::AsRegex.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request, and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Victoria-Casasampere-BeeTheData Victoria-Casasampere-BeeTheData marked this pull request as ready for review November 14, 2024 03:47
@wing328
Copy link
Member

wing328 commented Nov 14, 2024

@Victoria-Casasampere-BeeTheData thanks for the PR

cc @linxGnu

Copy link
Contributor

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much @Victoria-Casasampere-BeeTheData

@linxGnu
Copy link
Contributor

linxGnu commented Nov 14, 2024

@Victoria-Casasampere-BeeTheData

Please ensure that the integration test passed. You can use following command:

mvn clean && ./bin/generate-samples.sh bin/configs/manual/rust-axum-* && mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

@linxGnu
Copy link
Contributor

linxGnu commented Nov 15, 2024

@wing328
I checked out the patch from @Victoria-Casasampere-BeeTheData
Confirmed that the integration test passed.

Please merge this PR. Thank you!

@wing328 wing328 merged commit d7a23a9 into OpenAPITools:master Nov 15, 2024
20 checks passed
@wing328 wing328 added this to the 7.10.0 milestone Nov 15, 2024
@Victoria-Casasampere-BeeTheData Victoria-Casasampere-BeeTheData deleted the rust-axum-nullable-validator branch November 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants