-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Fix Circular imports on inherited discriminators. #17886
[python] Fix Circular imports on inherited discriminators. #17886
Conversation
@@ -10,6 +10,16 @@ import json | |||
{{{.}}} | |||
{{/vendorExtensions.x-py-model-imports}} | |||
|
|||
{{#hasChildren}}{{#discriminator}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR.
minor suggestions:
- use the following to avoid the empty line break
{{#hasChildren}}
{{#discriminator}}
...
{{/discriminator}}
{{/hasChildren}}
- for line 22 (empty line), move it between line 20 and 21 so that it will only be included when both hasChilden and discriminator are non-emtpy (or true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has been fixed.
lgtm. thanks for the fix 👍 |
…ols#17886) * [python] add inheritance discriminators test OpenAPITools#16808 * [python] update samples * [python] fix assert in test * [python] fix inheritance discriminators circular import * [python] update samples * [python] undo type changes related to discriminator * [python] remove extraneous processing * [python-pydantic-v1] fix inheritance discriminators circular import * [python] remove type ignore comment * [python] update samples * [python] fix avoid the empty line break * [python] update samples
Same as #17882, but passed type analysis and added a test
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)