Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rstudio upgrade #59512

Merged
merged 2 commits into from
May 23, 2019
Merged

Rstudio upgrade #59512

merged 2 commits into from
May 23, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 14, 2019
@aanderse
Copy link
Member

I built locally and ran the program. I haven't used R in over 10 years... but from the very little I could remember LGTM 👍

@aanderse
Copy link
Member

@GrahamcOfBorg build rstudio

@aanderse
Copy link
Member

@averelld after going through this in more detail I don't see any issues.
If I don't hear anything back from @ehmry, @changlinli, or @ciil in the next day or two we can go ahead and merge.

Thanks for your work on this 👍

ciil
ciil approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@ciil ciil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested some of my use cases, nothing broke, so lgtm. Thanks for updating!

@aanderse aanderse merged commit 408f62b into NixOS:master May 23, 2019
@aanderse
Copy link
Member

@averelld Sorry this took so long. Thanks again! 🎉

@averelld averelld deleted the rstudio-upgrade branch May 23, 2019 08:25
@changlinli
Copy link
Contributor

Late to the draw, but FWIW everything LGTM as well. My use cases still work. Thanks for the update!

@aanderse
Copy link
Member

@changlinli always nice to have extra validation. Thanks!

@veprbl veprbl mentioned this pull request Dec 8, 2019
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciil ciil ciil approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@averelld @aanderse @changlinli @ciil @GrahamcOfBorg