Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frawk: disable llvm support #381871

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

RossComputerGuy
Copy link
Member

Things done

Related ezrosent/frawk#115 & #305146

Disable LLVM support until upstream uses a version which is supported and isn't EOL.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomberek tomberek requested a review from figsoda February 23, 2025 05:08
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381871


x86_64-linux

✅ 1 package built:
  • frawk

aarch64-linux

✅ 1 package built:
  • frawk

x86_64-darwin

✅ 1 package built:
  • frawk

aarch64-darwin

✅ 1 package built:
  • frawk

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 24, 2025
@RossComputerGuy RossComputerGuy merged commit a8da3ac into NixOS:master Mar 6, 2025
7 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/frawk-llvm branch March 6, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants