Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmymoney: switch from qtwebkit to qtwebengine #201953

Merged
merged 3 commits into from
Nov 20, 2022
Merged

kmymoney: switch from qtwebkit to qtwebengine #201953

merged 3 commits into from
Nov 20, 2022

Conversation

das-g
Copy link
Member

@das-g das-g commented Nov 19, 2022 •
edited
Loading

Description of changes

Get rid of dependency on qtwebkit for KMyMoney and its dependencies, so that it build again despite qtwebkit having been marked known vulnerable by PR #201028. (See also QtWebKit deprecation issue #53079.)

  • switch from qtwebkit/kdewebkit to qtwebengine
    • alkimia
    • kmymoney
  • remove kdewebkit (as it's a library and as kmymoney was apparently the only thing in nixpkgs using it)
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@das-g das-g requested a review from ttuegel as a code owner November 19, 2022 19:28
@das-g das-g mentioned this pull request Nov 19, 2022
Merged
13 tasks
@das-g das-g mentioned this pull request Nov 19, 2022
Closed
69 tasks
@ofborg ofborg bot requested a review from aidalgol November 19, 2022 19:39
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 19, 2022
aidalgol
aidalgol approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@aidalgol aidalgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. KMyMoney appears to run normally, but I may not be using some features affected or disabled by this change.

@das-g
Copy link
Member Author

das-g commented Nov 19, 2022

Result of nixpkgs-review pr 201953 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.alkimia
  • libsForQt514.alkimia
2 packages built:
  • kmymoney
  • libsForQt5.alkimia

doronbehar
doronbehar reviewed Nov 19, 2022
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall.

das-g added 2 commits November 20, 2022 13:09
@das-g
kmymoney: switch from kdewebkit to qtwebengine
89739b5 
(to get rid of transitive dependency on qtwebkit)
See PR NixOS#201028 and issue NixOS#53079
@das-g
kdewebkit: remove
8d9eab4 
kdewebkit doesn't seem to be used anymore
and doesn't have any nixpkgs package maintainers.

I'm not sure whether the entry at
https://github.com/NixOS/nixpkgs/blob/6164b7bb61395b4488919ca4bbdf918d96a7d4ab/pkgs/development/libraries/kde-frameworks/srcs.nix#L230-L237
is also part of this, but that file has a DO NOT EDIT comment,
so I'm leaving it as-is.
@das-g das-g force-pushed the kmymoney-without-qtwebkit branch from 0f7f6dc to 8d9eab4 Compare November 20, 2022 12:10
@ofborg ofborg bot requested a review from aidalgol November 20, 2022 12:21
@das-g
Copy link
Member Author

das-g commented Nov 20, 2022

Result of nixpkgs-review pr 201953 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.alkimia
  • libsForQt514.alkimia
2 packages built:
  • kmymoney
  • libsForQt5.alkimia

@SuperSandro2000 SuperSandro2000 merged commit af24cba into NixOS:master Nov 20, 2022
@das-g das-g deleted the kmymoney-without-qtwebkit branch November 20, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

@aidalgol aidalgol Awaiting requested review from aidalgol

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@das-g @aidalgol @doronbehar @SuperSandro2000