apitrace: 7.1.old -> 11.1 #201032
Merged
apitrace: 7.1.old -> 11.1 #201032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from 2015 to current latest release.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg build apitrace |
69 tasks
Comment on lines
+1
to
+16
| { | ||
| lib, | ||
| stdenv, | ||
| fetchFromGitHub, | ||
| cmake, | ||
| pkg-config, | ||
| libX11, | ||
| procps, | ||
| python3, | ||
| libdwarf, | ||
| qtbase, | ||
| wrapQtAppsHook, | ||
| libglvnd, | ||
| gtest, | ||
| brotli, | ||
| }: |
There was a problem hiding this comment.
Can we please stop using incompatible formatters? Thanks!
| repo = "apitrace"; | ||
| rev = version; | ||
| hash = "sha256-rvC6iVWNNxH11hzQvRTo+SQi9jEUCPWGSdJmKJe9SQ0="; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
We should at least use our zlib, libpng and brotli.
There was a problem hiding this comment.
I believe it's using those to link statically so we can't really avoid that (unless we do some bad pkgsStatic things)
There was a problem hiding this comment.
Maybe that would be better than trusting upstream to update those dependencies and fix CVEs?
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update from 2015 to current latest release. Run-tested on glxgears, though I'd be very surprised if anyone noticed it break anyway.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes