Validator: Fail for stray ampersand characters #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @orgads I can see that after this PR we'll be doing 3 more checks per character in the given data which will impact the performance. Hence, I'm looking for options to minimize it. Eg when we find Let me know your opinion on this. |
|
Done, but I still need to add some unit tests. |
The following:
const xmlData = '<name length="bar" length="baz"></name>';
var expected = { code: 'InvalidAttr', msg: "Attribute 'length' is repeated.", line: 1 }
var result = validator.validate(xmlData).err;
expect(result).toEqual(expected);
Can be replaced by:
validate('<name length="bar" length="baz"></name>', { InvalidAttr: "Attribute 'length' is repeated." }
orgads
changed the title
|
@orgads Let me know once you're done. |
|
I'm done |
amitguptagwl
approved these changes
Dec 24, 2019
|
Thanks for the effort you spent. |
|
You're welcome. What about my other PR? |
|
That PR needs more time to review. As I'm out of the station for 1 more week, I'm not able to finish it. Will do it hopefull by 5th Jan. |
|
Sure, take your time :) |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
Type