Ekir 299 set removed license as unavailable #138
Merged
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NatLibFi-JoonaKupe
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set all removed licenses to status "unavailable".
Motivation and Context
Old licenses have been used for loans because circulation has had outdated information about them. This is due to the Licenses Info Documents having inaccurate information about
checkouts_left. The licenses had actually reached their loan limit and they had been removed from the feed. But because circulation reads the details from License Info Documents during each import to be in sync with the provider, and since that information could not have been read due to removing the licenses, the licenses were left as valid ones to be used for loans.Setting removed licenses to be "unavailable" will cause them to be ignored for loan checkouts and statistics.
How Has This Been Tested?
Unit test.
Checklist