Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dropdown menu width #1762

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fixed dropdown menu width #1762

merged 1 commit into from
Jan 30, 2025

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Jan 30, 2025

Reasons for creating this PR

A recent review showed weird behaviour in the search bar autocomplete, screenshots in the related issue.

Link to relevant issue(s), if any

Description of the changes in this PR

Apparently this was a regression caused by a recent commit with some sort of difficulties with merge (vocab-search.js, line -253, +260)

This PR reverts to the previous situation.

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added the bug label Jan 30, 2025
@joelit joelit added this to the 3.0 milestone Jan 30, 2025
@joelit joelit self-assigned this Jan 30, 2025
@joelit joelit requested a review from miguelvaara January 30, 2025 14:25
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joelit joelit merged commit 68e1564 into main Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

Search bar dropdown menu styling is inconsistent
2 participants