Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with rdflib 6.0.0 #87

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Fix compatibility with rdflib 6.0.0 #87

merged 4 commits into from
Aug 31, 2021

Conversation

osma
Copy link
Member

@osma osma commented Aug 30, 2021

Fixes #86

In rdflib 6.0.0, the RDF and RDFS namespaces were changed from ClosedNamespace to DeclaredNamespace (see RDFLib/rdflib#1074). This also dropped the .uri attribute that Skosify was relying on.

This PR switches to another way to get the URI of these namespaces (using str()). It works with both rdflib 5.0.0 and 6.0.0.

@osma osma added the bug label Aug 30, 2021
@osma osma self-assigned this Aug 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #87 (0eaa1c7) into master (0bcb8d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   59.24%   59.24%           
=======================================
  Files          11       11           
  Lines         930      930           
=======================================
  Hits          551      551           
  Misses        379      379           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcb8d7...0eaa1c7. Read the comment docs.

@osma osma merged commit 9e8b891 into master Aug 31, 2021
@osma osma deleted the issue86-rdflib-6-compat branch August 31, 2021 06:46
@osma osma added this to the 2.3.0 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skosify does not work with rdflib 6.0.0
2 participants