Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated import module #2182

Closed
wants to merge 1 commit into from
Closed

Fix duplicated import module #2182

wants to merge 1 commit into from

Conversation

lkm2835
Copy link
Contributor

@lkm2835 lkm2835 commented Sep 3, 2024

import tensorrt as trt is duplicated in line 25 and 29 at tensorrt_llm/runtime/generation.py

@lfr-0531
Copy link
Collaborator

lfr-0531 commented Sep 9, 2024

Thanks for your contribution to TRT-LLM, we'll merge you changes into internal code base.

@lfr-0531 lfr-0531 self-requested a review September 9, 2024 06:23
@lfr-0531 lfr-0531 self-assigned this Sep 9, 2024
@lfr-0531 lfr-0531 added the triaged Issue has been triaged by maintainers label Sep 9, 2024
@lfr-0531
Copy link
Collaborator

We've merged this PR into our internal code base.

@kaiyux kaiyux mentioned this pull request Sep 17, 2024
Merged
@kaiyux
Copy link
Member

kaiyux commented Sep 17, 2024

Hi @lkm2835 , we've integrated your changes (#2230), and marked you as co-author. Thanks a lot for your contribution and support.

I'm closing this PR, please feel free to let us know if there are any questions.

@kaiyux kaiyux closed this Sep 17, 2024
@lkm2835 lkm2835 deleted the fix branch September 17, 2024 13:44
@kaiyux kaiyux mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfr-0531 lfr-0531 Awaiting requested review from lfr-0531

Assignees

@lfr-0531 lfr-0531

Labels
Merged triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkm2835 @lfr-0531 @kaiyux