-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7124: add documentation for the new launch modes #158
7124: add documentation for the new launch modes #158
Conversation
Docs Build status updates of commit 32803a0: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 049a1f4: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit c227da4: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna block this only until the 1.5 release branch is created, so we can make sure to re-target this to the correct branch.
Also, you should add notes to make it clear which version these properties were added in.
Otherwise, great work here!
Docs Build status updates of commit 7a10c7b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
I created the release-1.5 branch and have pointed this PR towards that one. |
This PR documents new launch mode values introduced in microsoft/terminal#7873 to address microsoft/terminal#7124.
Not sure what is the correct contribution procedure for such changes. Hence, opening this change as a draft PR to master (please do not merge 😄 )