Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tooltip component on mobile #3177

Closed
FrederikBolding opened this issue Mar 3, 2025 · 1 comment · Fixed by MetaMask/metamask-mobile#13860
Closed

Implement Tooltip component on mobile #3177

FrederikBolding opened this issue Mar 3, 2025 · 1 comment · Fixed by MetaMask/metamask-mobile#13860
Assignees
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0

Comments

@FrederikBolding
Copy link
Member

No description provided.

@Daniel-Cross Daniel-Cross self-assigned this Mar 4, 2025
@eriknson
Copy link
Member

eriknson commented Mar 4, 2025

Design

tooltip-mechanic.mp4

@Daniel-Cross Daniel-Cross linked a pull request Mar 5, 2025 that will close this issue
7 tasks
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this issue Mar 8, 2025
## **Description**

Implementation of the Tooltip component for Snaps UI Renderer.

## **Related issues**

Fixes:
MetaMask/snaps#3177

## **Manual testing steps**

1. Go to the webview for snaps testing
(https://metamask.github.io/snaps/test-snaps/latest/)
2. Scroll down and install JSX Snap. Then press 'Show JSX Snap'
3. Press the Tooltip to see a bottom sheet pop over on the screen with
populated information

## **Screenshots/Recordings**


https://github.com/user-attachments/assets/51b2e503-6cf9-48e7-adf4-0bc6a3495669


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants