Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(4173): Send flow with contextual chain selector #13938

Draft
wants to merge 3 commits into
base: feat-4144-per-dapp-selected-network-poc-2
Choose a base branch
from
Draft

feat(4173): Send flow with contextual chain selector #13938

wants to merge 3 commits into from
+101 −15

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Mar 10, 2025 •
edited
Loading

Description

Send flow to use contextual chain selector, WIP.

Related issues

Contributes to: #13674

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 changed the base branch from main to feat-4144-per-dapp-selected-network-poc-2 March 10, 2025 13:57
@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 10, 2025
@EtherWizard33 EtherWizard33 added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Mar 10, 2025
@EtherWizard33
feat: track contextual chain id for send flow
d27e30f 
This commit:
- Adds redux state to track chain ID specifically in send flow context
- Dispatches chain ID updates when switching networks from send flow
- Adds selector and logging to monitor contextual chain ID changes
- Only tracks chain ID when network selector is used from send flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EtherWizard33