Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Base to Smart Transaction supported chains #13920

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

httpJunkie
Copy link
Contributor

Description

What is the reason for the change?

Smart Transactions are currently supported on Ethereum Mainnet and BNB Smart Chain, but not on Base. As part of our effort to expand Smart Transactions functionality to more networks, Base needs to be added to the list of supported chains.

What is the improvement/solution?

This PR adds Base to the list of supported chains for Smart Transactions in the extension by:

  • Adding CHAIN_IDS.BASE to ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT
  • Adding CHAIN_IDS.BASE to ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_PRODUCTION
  • Updating tests to include Base in the expected supported chains list

These changes allow the extension to recognize Base as a valid network for Smart Transactions, enabling users to benefit from Smart Transactions functionality when interacting with the Base network.

Open in GitHub Codespaces

Related issues

Fixes: TXL-697 TXL-699

Manual testing steps

Since Base isn't supported yet and this PR simply adds Base to list of supported chains, we are not testing Base/STX functionality yet, but ensuring that existing functionality remains intact.

This PR updates the version of @metamask/smart-transactions-controller, confirm that it doesn't break anything. Manual testing included:

  • Verifying STX still works correctly on Ethereum Mainnet (see screenshot image)
  • Checking that network switching between supported networks maintains proper STX state
  • Ensuring STX settings UI correctly displays supported networks
  • Confirming swap transactions with STX enabled complete successfully
  • Ensuring that STX Description in Advanced Settings is correctly updated (see before/after images)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@httpJunkie httpJunkie requested a review from a team as a code owner March 7, 2025 15:06
Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-transactions Transactions team INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 7, 2025
@httpJunkie httpJunkie added release-7.43.0 Issue or pull request that will be included in release 7.43.0 and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 7, 2025
@httpJunkie
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

sonarqubecloud bot commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants